Re: [Minios-devel] [UNIKRAFT/LIBNEWLIB PATCH] Add libvfscore as dependency

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Simon

This patch seems fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 4/10/19 10:32 AM, Simon Kuenzer wrote:
> The current implementation requires libvfscore to be selected. Without
> libvfscore `read`, `write`, `close`, and `fstat` are undefined and
> linking fails. With this commit we also fix a typo in the dependency
> definition to libukalloc.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   Config.uk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Config.uk b/Config.uk
> index b75dbcd..89010a1 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -8,4 +8,5 @@ menuconfig LIBNEWLIBC
>         default n
>         select HAVE_LIBC
>         select LIBNEWLIBM if LIBNEWLIBC
> -       select LIBUCALLOC
> +       select LIBUKALLOC
> +       select LIBVFSCORE
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel