Re: [Minios-devel] [UNIKRAFT PATCHv4 2/9] plat/kvm: Add build support for internal fdt interfaces

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Jia He,

Please find the comments inline.

Thanks & Regards
Sharan

On 3/27/19 3:34 AM, Jia He wrote:
> This enable the build support for fdt interfaces for later commits.
> These interfaces are the helpers for arm64 interrupt controller gic
> initialization.
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/kvm/Makefile.uk | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/plat/kvm/Makefile.uk b/plat/kvm/Makefile.uk
> index ad611d3..8bb2d47 100644
> --- a/plat/kvm/Makefile.uk
> +++ b/plat/kvm/Makefile.uk
> @@ -17,6 +17,7 @@ LIBKVMPLAT_ASINCLUDES-y        += -I$(LIBKVMPLAT_BASE)/include
>   LIBKVMPLAT_ASINCLUDES-y        += -I$(UK_PLAT_COMMON_BASE)/include
>   LIBKVMPLAT_CINCLUDES-y         += -I$(LIBKVMPLAT_BASE)/include
>   LIBKVMPLAT_CINCLUDES-y         += -I$(UK_PLAT_COMMON_BASE)/include
It is not wise to cross reference a library from platform. I think this 
relates to the comments in the previous patch.
> +LIBKVMPLAT_CINCLUDES-$(CONFIG_ARCH_ARM_64)         += -I$(LIBFDT_BASE)/
>   
>   LIBKVMPLAT_ASFLAGS             += -DKVMPLAT
>   LIBKVMPLAT_CFLAGS              += -DKVMPLAT
> @@ -64,6 +65,7 @@ LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/cache64.S|co
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/psci_arm64.S|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/time.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/traps.c|common
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(UK_PLAT_COMMON_BASE)/fdt.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/entry64.S
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/exceptions.S
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/pagetable64.S
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel