Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 1/1] Add sys/types.h to the mman header

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad,

Thanks for the patch, looks good. Just a few minor grammar things in the commit 
message which I'll fix on upstreaming.

— Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 26.03.19, 13:16, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    The mman.h header is take from musl but
    it does not include the bits/alltypes.h
    and such off_t and size_t are not defined.
    This patch adds the sys/types.h header
    which has the missing typedefs.
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     include/sys/mman.h | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/include/sys/mman.h b/include/sys/mman.h
    index 7abf57f..0981a4b 100644
    --- a/include/sys/mman.h
    +++ b/include/sys/mman.h
    @@ -31,6 +31,7 @@ extern "C" {
     #endif
     
     #include <stddef.h>
    +#include <sys/types.h>
     
     #define __NEED_mode_t
     #define __NEED_size_t
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel