Re: [Minios-devel] [UNIKRAFT PATCH 4/4] plat/kvm: Remove superfluous pushes in early boot code

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

looks good to me.
Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

BR, Yuri.

Florian Schmidt <florian.schmidt@xxxxxxxxx> writes:

> These seem to be a leftover from porting code from solo5, but don't
> serve a purpose in our booting process.
>
> Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
> ---
>  plat/kvm/x86/entry64.S | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/plat/kvm/x86/entry64.S b/plat/kvm/x86/entry64.S
> index 8abc8efb..828cd1bc 100644
> --- a/plat/kvm/x86/entry64.S
> +++ b/plat/kvm/x86/entry64.S
> @@ -231,9 +231,6 @@ nofsgsbase:
>       /* read multiboot info pointer */
>       popq %rdi
>  
> -     pushq $0x0
> -     pushq $0x0
> -
>       call _libkvmplat_entry
>  
>       cli
> -- 
> 2.21.0
>

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel