Re: [Minios-devel] [UNIKRAFT PATCH] build: plat library are build even when disabled

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

Patch looks good, thanks. I might modify the commit message slightly to make it 
a bit clearer that this prevents the build system from building 
platform-specific options that are disabled when the corresponding platform is 
enabled.

— Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

============================================================
Dr. Felipe Huici
Chief Researcher, Systems and Machine Learning Group
NEC Laboratories Europe GmbH
Kurfuerstenanlage 36, D-69115 Heidelberg
Tel.  +49
(0)6221 4342-241
Fax:  +49
(0)6221 4342-155
 
e-mail:
felipe.huici@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

On 07.03.19, 11:21, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
sharan.santhanam@xxxxxxxxx> wrote:

    Platform library is built even when the configuration is
    disabled. This is fixed by using conditional expansion
    instead of conditional-directives.
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     support/build/Makefile.rules | 4 +---
     1 file changed, 1 insertion(+), 3 deletions(-)
    
    diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
    index 999e17e..926a533 100644
    --- a/support/build/Makefile.rules
    +++ b/support/build/Makefile.rules
    @@ -167,9 +167,7 @@ endef
    
     # addplatlib_s $platname,$libname,$switch
     define addplatlib_s =
    -ifeq ($(3),y)
    -$(call addplatlib,$(1),$(2))
    -endif
    +$(if $(filter y,$(3)),$(call addplatlib,$(1),$(2)),)
     endef
    
    
    --
    2.7.4
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel