Re: [Minios-devel] [PATCH] doc/*: Update directory structure in documentation

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Juan,

Thanks for the fix, looks good!

— Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 11.03.19, 20:40, "Juan Picca" <jumapico@xxxxxxxxx> wrote:

    As noted in 
https://wiki.xenproject.org/wiki/Unikraft_Incubation_Project_Proposal,
    the project is using the structure unikraft/libs instead of unikraft-libs.
    
    This is reflected in all the current examples:
    https://xenbits.xen.org/gitweb/?a=project_list;pf=unikraft/apps
    
    Signed-off-by: Juan Picca <jumapico@xxxxxxxxx>
    ---
     doc/guides/developers-app.rst | 2 +-
     doc/guides/users.rst          | 8 ++++----
     2 files changed, 5 insertions(+), 5 deletions(-)
    
    diff --git a/doc/guides/developers-app.rst b/doc/guides/developers-app.rst
    index 8974824..d1b8bfa 100644
    --- a/doc/guides/developers-app.rst
    +++ b/doc/guides/developers-app.rst
    @@ -39,7 +39,7 @@ Linux kernel modules that are built off-tree. For most 
applications
     the Makefile should contain no more than the following: ::
    
       UK_ROOT ?= $(PWD)/../../unikraft
    -  UK_LIBS ?= $(PWD)/../../unikraft-libs
    +  UK_LIBS ?= $(PWD)/../../libs
       LIBS := $(UK_LIBS)/lib1:$(UK_LIBS)/lib2:$(UK_LIBS)/libN
    
       all:
    diff --git a/doc/guides/users.rst b/doc/guides/users.rst
    index 7f41a95..d590efc 100644
    --- a/doc/guides/users.rst
    +++ b/doc/guides/users.rst
    @@ -24,20 +24,20 @@ cloned the repos above. For instance, assuming the 
following directory
     structure ::
    
       ├── unikraft
    -  ├── unikraft-apps
    +  ├── apps
       │  ├── helloworld
       │  ├── app1
       │  ├── app2
    -  └── unikraft-libs
    +  └── libs
          ├── lib1
          ├── lib2
          └── libN
    
    -where your app is located at ``unikraft-apps/helloworld``, you would set
    +where your app is located at ``apps/helloworld``, you would set
     those variables as follows: ::
    
       UK_ROOT ?= $(PWD)/../../unikraft
    -  UK_LIBS ?= $(PWD)/../../unikraft-libs
    +  UK_LIBS ?= $(PWD)/../../libs
    
     Finally, if your app will be using external libraries, set the ``LIBS``
     variable to reflect this. For instance : ::
    --
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel