Re: [Minios-devel] [UNIKRAFT] Xen PVH platform

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Mar 12, 2019 at 04:47:16PM +0000, Wei Liu wrote:
> Off topic: can I suggest you s/HVMLITE/PVH/ ?

Actually, that's also a good question - multiple parts about PVH
internally are named HVM (for example HVMOP_get_param). Which kind of
makes sense, but doesn't ease naming things.

So, is

    #ifdef CONFIG_XEN_PVH

        ...
        HYPERVISOR_hvm_op(HVMOP_get_param, ...)
    #endif

ok?

To be honest, I'm not sure if some parts wouldn't also make sense in
actual HVM, where putting them under CONFIG_XEN_PVH would be even more
confusing... Not sure why would anyone want to do that, but that's yet
another thing possibly affecting names here.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel