Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH v2 2/2] add declarations needed for vfscore in the gluecode

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Yuri,

this looks good, except for two phrasings, but I'll fix them on 
upstreaming (see below), unless you object to my rephrasing.
Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 3/5/19 7:29 PM, Yuri Volchkov wrote:
> +/* Glibc does not provide KEEP_SIZE and PUNCH_HOLE anymore. Instead it
> + * includes linux/falloc.h.
> + *
> + * Musl still does provide them. And Newlib is just does not care.
> + */
s/Newlib is just/Newib just/

> +#ifdef __rtems__
> +#error "The __rtems__ is defined. Please revisit this header wrapper"
> +#endif
s/The __rtems__ is defined/Unexpected definition of __rtems__/


--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel