Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 1/2] update newlib glue for use with vfscore

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Yuri,

this looks fine for the most part. One comment:

On 3/4/19 6:54 PM, Yuri Volchkov wrote:

> diff --git a/include/sys/uio.h b/include/sys/uio.h
> new file mode 100644
> index 0000000..cfec9cc
> --- /dev/null
> +++ b/include/sys/uio.h
> @@ -0,0 +1,74 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/*
> + * Copyright (C) 2013 Cloudius Systems, Ltd.
> + * Copyright (c) 2019, NEC Europe Ltd., NEC Corporation.
> + *
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of the copyright holder nor the names of its
> + *    contributors may be used to endorse or promote products derived from
> + *    this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
> + */
> +
> +#ifndef _SYS_UIO_H
> +#define _SYS_UIO_H
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#define __NEED_size_t
> +#define __NEED_ssize_t
> +#define __NEED_struct_iovec
> +
> +#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
> +#define __NEED_off_t
> +#endif
> +
> +#ifdef _GNU_SOURCE
> +#define __NEED_pid_t
> +#endif
I don't think these __NEED macros are going to do anything nolibc's 
shareddefs.h? So they're effectively noops, and might actually confuse 
someone reading that code that they get size_t, ssize_t, ... from 
somewhere when effectively, they get nothing. I would remove these.
And in fact, when I checked the code yet, I noticed there is no pid_t 
definition in shareddefs.h at all, so it looks like something slipped in 
there. Either we need to provide a definition, or we need to remove the 
__NEED_pid_t macro; but that's out of scope for this patch series, and 
I'll look into this separately.
Cheers,
Florian

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel