Re: [Minios-devel] [UNIKRAFT PATCH 5/5] lib/vfscore: fix checkpatch issues for uio.h and statfs.h

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 3/4/19 6:46 PM, Yuri Volchkov wrote:
> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
> ---
>   lib/nolibc/include/sys/statfs.h | 4 ++--
>   lib/nolibc/include/sys/uio.h    | 8 ++++----
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/nolibc/include/sys/statfs.h b/lib/nolibc/include/sys/statfs.h
> index f3eccab6..59de6299 100644
> --- a/lib/nolibc/include/sys/statfs.h
> +++ b/lib/nolibc/include/sys/statfs.h
> @@ -19,8 +19,8 @@ struct statfs {
>         unsigned long f_namelen, f_frsize, f_flags, f_spare[4];
>   };
>   
> -int statfs (const char *, struct statfs *);
> -int fstatfs (int, struct statfs *);
> +int statfs(const char *path, struct statfs *buf);
> +int fstatfs(int fd, struct statfs *buf);
>   
>   #if defined(_LARGEFILE64_SOURCE) || defined(_GNU_SOURCE)
>   #define statfs64 statfs
> diff --git a/lib/nolibc/include/sys/uio.h b/lib/nolibc/include/sys/uio.h
> index cdfbec9b..d1a4b48d 100644
> --- a/lib/nolibc/include/sys/uio.h
> +++ b/lib/nolibc/include/sys/uio.h
> @@ -56,12 +56,12 @@ extern "C" {
>   
>   #define UIO_MAXIOV 1024
>   
> -ssize_t readv (int, const struct iovec *, int);
> -ssize_t writev (int, const struct iovec *, int);
> +ssize_t readv(int fd, const struct iovec *iov, int iovcnt);
> +ssize_t writev(int fd, const struct iovec *iov, int iovcnt);
>   
>   #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
> -ssize_t preadv (int, const struct iovec *, int, off_t);
> -ssize_t pwritev (int, const struct iovec *, int, off_t);
> +ssize_t preadv(int fd, const struct iovec *iov, int iovcnt, off_t offset);
> +ssize_t pwritev(int fd, const struct iovec *iov, int iovcnt, off_t offset);
>   #if defined(_LARGEFILE64_SOURCE) || defined(_GNU_SOURCE)
>   #define preadv64 preadv
>   #define pwritev64 pwritev
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel