Re: [Minios-devel] [UNIKRAFT PATCHv6 08/23] plat/common: Add referred source code URL for cache operation

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Jia He,

It would be wise to add the 12-digit git commit identifier from freebsd.

Thanks & Regards
Sharan

On 2/22/19 7:21 AM, Jia He wrote:
> From: Wei Chen <wei.chen@xxxxxxx>
> We'd better to mention where our code comes from, this helps to
> check whether code has been updated afterwards.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/common/arm/cache64.S | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/plat/common/arm/cache64.S b/plat/common/arm/cache64.S
> index bada417..eab7a73 100644
> --- a/plat/common/arm/cache64.S
> +++ b/plat/common/arm/cache64.S
> @@ -1,5 +1,8 @@
>   /* SPDX-License-Identifier: BSD-3-Clause */
>   /*
> + * This source code is based on:
> + * github.com/freebsd/freebsd/blob/de41c46/sys/arm64/arm64/cpufunc_asm.S
> + *
>    * Authors: Wei Chen <wei.chen@xxxxxxx>
>    *
>    * Copyright (c) 2014 Robin Randhawa
> --
> 2.17.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended recipient, 
> please notify the sender immediately and do not disclose the contents to any 
> other person, use it for any purpose, or store or copy the information in any 
> medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel