Re: [Minios-devel] [UNIKRAFT PATCH] lib/nolibc: Provide stdbool.h

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

On 18.02.19, 19:01, "Sharan Santhanam" <Sharan.Santhanam@xxxxxxxxx> wrote:

    Hello Simon,
    
    Please find the comments inline.
    
    Thanks & Regards
    Sharan
    
    On 2/18/19 4:04 PM, Simon Kuenzer wrote:
    > Introduce a minimal `stdbool.h` header that provides definitions
    > of `bool`, `true`, and `false`.
    > 
    > Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    > ---
    >   lib/nolibc/include/stdbool.h | 55 
++++++++++++++++++++++++++++++++++++++++++++
    >   1 file changed, 55 insertions(+)
    >   create mode 100644 lib/nolibc/include/stdbool.h
    > 
    > diff --git a/lib/nolibc/include/stdbool.h b/lib/nolibc/include/stdbool.h
    > new file mode 100644
    > index 00000000..9c7de598
    > --- /dev/null
    > +++ b/lib/nolibc/include/stdbool.h
    > @@ -0,0 +1,55 @@
    > +/* SPDX-License-Identifier: BSD-3-Clause */
    > +/*
    > + * Authors: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    > + *
    > + *
    > + * Copyright (c) 2019, NEC Laboratories Europe GmbH, NEC Corporation.
    > + *                     All rights reserved.
    > + *
    > + * Redistribution and use in source and binary forms, with or without
    > + * modification, are permitted provided that the following conditions
    > + * are met:
    > + *
    > + * 1. Redistributions of source code must retain the above copyright
    > + *    notice, this list of conditions and the following disclaimer.
    > + * 2. Redistributions in binary form must reproduce the above copyright
    > + *    notice, this list of conditions and the following disclaimer in the
    > + *    documentation and/or other materials provided with the 
distribution.
    > + * 3. Neither the name of the copyright holder nor the names of its
    > + *    contributors may be used to endorse or promote products derived 
from
    > + *    this software without specific prior written permission.
    > + *
    > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
"AS IS"
    > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR 
CONTRIBUTORS BE
    > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR 
BUSINESS
    > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER 
IN
    > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 
OTHERWISE)
    > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 
OF THE
    > + * POSSIBILITY OF SUCH DAMAGE.
    > + *
    > + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
    > + */
    > +
    > +#ifndef __STDBOOL_H__
    > +#define __STDBOOL_H__
    > +
    > +#ifdef __cplusplus
    > +extern "C" {
    > +#endif
    > +
    > +#define bool _Bool_Bool is a GNU extension in C++. Do we want to use 
this in C++ as we 
    have a language provided bool datatype. If we must use it shouldn't we 
    check for __GNUC__ macro as described in [1].
    
    [1] http://tigcc.ticalc.org/doc/gnuexts.html

No problem, I can add such a check. Thanks!

    
    > +
    > +#define true (1)
    > +#define false (0)
    > +
    > +#define __bool_true_false_are_defined (1)
    > +
    > +#ifdef __cplusplus
    > +}
    > +#endif
    > +
    > +#endif /* __STDBOOL_H__ */
    > 
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel