[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH] build: Notice user when to do `make clean`



Hello Simon,

This patch seems fine.


Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 2/11/19 6:01 PM, Simon Kuenzer wrote:
The little helper script `configupdate` did not detect any config changes
with `.config` anymore because it did prefix `CONFIG_` prefix for the
configuration symbols.
This commit makes sure that `configupdate` can detect changes
(e.g., CPU architecture, code optimizations) that requires `make clean`
before continuing. It is still called automatically by the build system.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
  support/scripts/configupdate | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/support/scripts/configupdate b/support/scripts/configupdate
index fed14430..ce5ce986 100755
--- a/support/scripts/configupdate
+++ b/support/scripts/configupdate
@@ -23,13 +23,13 @@ NL=$'\n'
  [ -z "${UK_CONFIG_OLD}" -o ! -e "${UK_CONFIG_OLD}" ] && exit 0
# Change of architecture?
-_comparesym "ARCH_" "${UK_CONFIG}" "${UK_CONFIG_OLD}" || UPDATES+="***  - CPU 
architecture changed${NL}"
+_comparesym "CONFIG_ARCH_" "${UK_CONFIG}" "${UK_CONFIG_OLD}" || UPDATES+="*** - CPU 
architecture changed${NL}"
# Change of CPU options?
-_comparesym "MARCH_" "${UK_CONFIG}" "${UK_CONFIG_OLD}" || UPDATES+="***  - CPU 
optimization changed${NL}"
+_comparesym "CONFIG_MARCH_" "${UK_CONFIG}" "${UK_CONFIG_OLD}" || UPDATES+="*** - 
CPU optimization changed${NL}"
# Change of optimizations?
-_comparesym "OPTIMIZE_" "${UK_CONFIG}" "${UK_CONFIG_OLD}" || UPDATES+="*** - Code 
optimization changed${NL}"
+_comparesym "CONFIG_OPTIMIZE_" "${UK_CONFIG}" "${UK_CONFIG_OLD}" || UPDATES+="*** - 
Code optimization changed${NL}"
if [ ! -z "$UPDATES" ]; then
        echo "*** The following configuration changes were detected:"


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.