Re: [Minios-devel] [UNIKRAFT PATCH] support: don't throw error message when not in a git repo

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks for this fix!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 17.01.19, 13:39, "Florian Schmidt" <Florian.Schmidt@xxxxxxxxx> wrote:

    The gitsha1 script is used to create a version string for unikraft that
    includes the git hash. However, if we are not building from a git repo
    checkout, it will throw error messages on the command line. Suppress
    these because there's little gain in them.
    
    Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    ---
     support/scripts/gitsha1 | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/support/scripts/gitsha1 b/support/scripts/gitsha1
    index f4b77d7b..b86e4a77 100755
    --- a/support/scripts/gitsha1
    +++ b/support/scripts/gitsha1
    @@ -1,6 +1,6 @@
     #!/bin/sh
    -V=`git rev-parse --short HEAD`
    -D=`git ls-files -m`
    +V=`git rev-parse --short HEAD 2>/dev/null`
    +D=`git ls-files -m 2>/dev/null`
     if [ "z$V" != "z" ]
     then
        if [ "z$D" != "z" ]
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel