Re: [Minios-devel] [UNIKRAFT PATCH v2 3/3] build: `print-libs`, `print-objs`, `print-srcs` depend on `.config`

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Simon,

This patch seems fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 1/31/19 12:12 PM, Simon Kuenzer wrote:
> As soon as no configuration `.config` is available, the Make targets
> `print-libs`, `print-objs`, and `print-srcs` will return an error
> message. Without a configuration file these targets are not able
> to do any listing of which units are used or created by a build.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   Makefile | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 57567c1a..b9041f5b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -556,7 +556,7 @@ clean:
>   
>   endif
>   
> -.PHONY: print-vars print-libs help outputmakefile list-defconfigs
> +.PHONY: print-vars print-libs print-objs print-srcs help outputmakefile 
> list-defconfigs
>   
>   # Configuration
>   # ---------------------------------------------------------------------------
> @@ -701,6 +701,7 @@ print-vars:
>   print-version:
>         @echo $(UK_FULLVERSION)
>   
> +ifeq ($(UK_HAVE_DOT_CONFIG),y)
>   print-libs:
>         @echo   $(foreach P,$(UK_PLATS) $(UK_PLATS-y),\
>                 $(if $(call qstrip,$($(call uc,$(P))_LIBS) $($(call 
> uc,$(P))_LIBS-y)),\
> @@ -735,6 +736,16 @@ print-srcs:
>                 $(if $(call qstrip,$($(call vprefix_lib,$(L),SRCS)) $($(call 
> vprefix_lib,$(L),SRCS-y))),\
>                 '$(L):\n   $($(call vprefix_lib,$(L),SRCS)) $($(call 
> vprefix_lib,$(L),SRCS-y))\n'\
>                 ))
> +else
> +print-libs:
> +       $(error Do not have a configuration. Please run one of the 
> configuration targets first)
> +
> +print-objs:
> +       $(error Do not have a configuration. Please run one of the 
> configuration targets first)
> +
> +print-srcs:
> +       $(error Do not have a configuration. Please run one of the 
> configuration targets first)
> +endif
>   
>   help:
>         @echo 'Cleaning:'
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel