Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukdebug: Fix spelling in configuration menu

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Simon,

This patch seems fine.


Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 1/31/19 12:44 AM, Simon Kuenzer wrote:
> The help text of LIBUKDEBUG_PRINTK was speaking about debug messages
> although the option configures kernel messages.
> The option LIBUKDEBUG_PRINTK_INFO enables all types of kernel messages
> instead of debug messages.
> The message redirection option does not have a dependency on
> LIBUKDEBUG_PRINTD neither on LIBUKDEBUG_PRINTK.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   lib/ukdebug/Config.uk | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/ukdebug/Config.uk b/lib/ukdebug/Config.uk
> index 532f926b..746ac3de 100644
> --- a/lib/ukdebug/Config.uk
> +++ b/lib/ukdebug/Config.uk
> @@ -15,10 +15,10 @@ choice
>         default LIBUKDEBUG_PRINTK_ERR
>         depends on LIBUKDEBUG_PRINTK
>         help
> -         Set the level of detail of debug messages
> +         Set the level of detail of kernel messages
>   
>   config LIBUKDEBUG_PRINTK_INFO
> -       bool "Show all types of debug messages"
> +       bool "Show all types of messages"
>   
>   config LIBUKDEBUG_PRINTK_WARN
>         bool "Show critical, error, and warning messages"
> @@ -41,7 +41,6 @@ config LIBUKDEBUG_PRINTD
>   choice
>         prompt "Message redirection"
>         default LIBUKDEBUG_REDIR_PRINTD
> -       depends on LIBUKDEBUG_PRINTD || LIBUKDEBUG_PRINTK
>         help
>           Output for uk_printk() and uk_printd()
>   
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel