Re: [Minios-devel] [UNIKRAFT PATCH v2 1/3] lib/uklock: rename mutex functions to match pthread_ analogues

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Yuri,

This patch seems fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On the side note, this patch breaks the compatibility with the lwip 
library that depends on this API. A new update to the lwip library is 
expected very soon.
Thanks & Regards
Sharan

On 1/9/19 12:33 PM, Yuri Volchkov wrote:
> People are more used to functions like mutex_lock and mutex_unlock,
> then mutex_hold and mutex_release.
>
> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
> ---
>   lib/uklock/include/uk/mutex.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/uklock/include/uk/mutex.h b/lib/uklock/include/uk/mutex.h
> index 7b0208a3..96635f6b 100644
> --- a/lib/uklock/include/uk/mutex.h
> +++ b/lib/uklock/include/uk/mutex.h
> @@ -60,7 +60,7 @@ struct uk_mutex {
>   
>   void uk_mutex_init(struct uk_mutex *m);
>   
> -static inline void uk_mutex_hold(struct uk_mutex *m)
> +static inline void uk_mutex_lock(struct uk_mutex *m)
>   {
>         unsigned long irqf;
>   
> @@ -77,7 +77,7 @@ static inline void uk_mutex_hold(struct uk_mutex *m)
>         ukplat_lcpu_restore_irqf(irqf);
>   }
>   
> -static inline int uk_mutex_hold_try(struct uk_mutex *m)
> +static inline int uk_mutex_trylock(struct uk_mutex *m)
>   {
>         unsigned long irqf;
>         int ret = 0;
> @@ -91,7 +91,7 @@ static inline int uk_mutex_hold_try(struct uk_mutex *m)
>         return ret;
>   }
>   
> -static inline void uk_mutex_release(struct uk_mutex *m)
> +static inline void uk_mutex_unlock(struct uk_mutex *m)
>   {
>         unsigned long irqf;
>   
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel