Re: [Minios-devel] [UNIKRAFT PATCH v2 00/11] import linux-like linked lists from FreeBSD

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Yuri,

Thanks for this patch series. This patch series is ready to be upstreamed.

Thanks & Regards
Sharan

On 1/25/19 3:09 PM, Yuri Volchkov wrote:
> The imported implementation is a bit more easy to use and
> understand. Unikraft will benefit from this code in improved
> readability.
>
> This list implementation will replace the old one soon. However this
> series keeps both lists. The reasons for that are following:
>
>   - to reduce the number of patches, this series converts only a couple
>     of libraries
>
>   - to give some time for ongoing development to switch to the new api
>
> The "resolve common symbols in each lib individually" looks like
> unrelated bug fix. But after the patch "use new list api" the symbol
> "uk_bus_list" is not common anymore, and it can not sneak through
> library symbol isolation - which is one of the effects of the bug.
>
> Changes sinc v1:
>   - Fix possible C++ issues
>   - Advance further in fixing checkpatch complains
>   - Use uk_list_del_init instead of uk_list_del
>
> Yuri Volchkov (11):
>    build: resolve common symbols in each lib individually
>    include/uk: import write_once and read_once from freebsd
>    include/uk/list: import linux linked list code from freebsd
>    include/uk/list: rename UK_LIST_HEAD in the old implementation
>    include/uk/list: adapt imported code for Unikraft
>    include/uk/list: remove unneeded workarounds from imported code
>    include/uk/list: prefix imported functions with uk_
>    include/uk/list: fix style issues
>    include/uk/list: update license header for imported code
>    lib/ukbus: use new list api
>    plat/common/pci: use new list api
>
>   Makefile.uk                          |    2 +-
>   include/uk/arch/atomic.h             |   17 +
>   include/uk/{list.h => compat_list.h} |    2 +-
>   include/uk/list.h                    | 1110 ++++++++------------------
>   lib/ukbus/bus.c                      |    9 +-
>   lib/ukbus/exportsyms.uk              |    1 +
>   lib/ukbus/include/uk/bus.h           |   15 +-
>   plat/common/include/pci/pci_bus.h    |    6 +-
>   plat/common/pci_bus.c                |   28 +-
>   9 files changed, 373 insertions(+), 817 deletions(-)
>   copy include/uk/{list.h => compat_list.h} (99%)
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel