Re: [Minios-devel] [UNIKRAFT PATCH 10/11] lib/ukbus: use new list api

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi, 

Sharan Santhanam <sharan.santhanam@xxxxxxxxx> writes:

> Hello Yuri,
>
> Please find the comment inline.
>
> Thanks & Regards
> Sharan
>
> On 12/5/18 6:23 PM, Yuri Volchkov wrote:
>> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
>> ---
>>   lib/ukbus/bus.c            |  9 +++------
>>   lib/ukbus/include/uk/bus.h | 15 ++++-----------
>>   2 files changed, 7 insertions(+), 17 deletions(-)
>> 
>> diff --git a/lib/ukbus/bus.c b/lib/ukbus/bus.c
>> index b8aaf22..3b3f3b3 100644
>> --- a/lib/ukbus/bus.c
>> +++ b/lib/ukbus/bus.c
>>   
>> @@ -58,7 +55,7 @@ void _uk_bus_unregister(struct uk_bus *b)
>>      UK_ASSERT(bus_count > 0);
>>   
>>      uk_pr_debug("Unregister bus handler: %p\n", b);
>> -    UK_TAILQ_REMOVE(&uk_bus_list, b, next);
>> +    uk_list_del(&b->list);
> uk_list_del has some dangling reference to the list. In this case it may 
> not be a big problem. But isn't it better to use uk_list_del_init instead?
I guess it would not hurt. Here and for the next patch as well.

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel