Re: [Minios-devel] [UNIKRAFT PATCH v2 3/8] lib/uksched: Introduce thread attributes

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Costin,

I checked Felipe's comments, and I agree with your changes in v2. he 
patch looks good to me, except for one minor thing:
On 1/11/19 12:22 AM, Costin Lupu wrote:
> diff --git a/lib/uksched/include/uk/thread_attr.h 
> b/lib/uksched/include/uk/thread_attr.h
> new file mode 100644
> index 0000000..93dcd5c
> --- /dev/null
> +++ b/lib/uksched/include/uk/thread_attr.h
> @@ -0,0 +1,81 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/*
> + * Authors: Costin Lupu <costin.lupu@xxxxxxxxx>
> + *
> + * Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of the copyright holder nor the names of its
> + *    contributors may be used to endorse or promote products derived from
> + *    this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
> + */
> +
> +#ifndef __UK_SCHED_THREAD_ATTR_H__
> +#define __UK_SCHED_THREAD_ATTR_H__
> +
> +#include <uk/arch/time.h>
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#define UK_THREAD_ATTR_WAITABLE         0
> +#define UK_THREAD_ATTR_DETACHED         1
> +
> +#define UK_THREAD_ATTR_PRIO_INVALID     (-1)
> +#define UK_THREAD_ATTR_PRIO_MIN         0
> +#define UK_THREAD_ATTR_PRIO_MAX         255
> +#define UK_THREAD_ATTR_PRIO_DEFAULT     127
> +
> +#define UK_THREAD_ATTR_TIMESLICE_NIL    0
> +
> +typedef int prio_t;
> +
> +typedef struct uk_thread_attr {
> +       /**< Is non-zero if thread should detach */
> +       int is_detached;
> +       /**< Priority */
> +       prio_t prio;
> +       /**< Time slice in nanoseconds */
Is there some reason for this comment style? (double-asterisk and less-than)


Cheers,
Florian

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel