Re: [Minios-devel] [UNIKRAFT PATCHv3 17/25] plat/kvm: Invalidate D-Cache that may have been modified for Arm64

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Wei Chen,

This patch is fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 12/13/18 10:15 AM, Wei Chen wrote:
> DTB, TEXT and RODATA would not be modified while booting, so we just
> need to invalidate and clean the area that may have been modified:
> DATA, BSS, PAGETABLE and BOOTSTACK.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> ---
>   plat/kvm/arm/pagetable64.S | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/plat/kvm/arm/pagetable64.S b/plat/kvm/arm/pagetable64.S
> index d4abaff..cf30584 100644
> --- a/plat/kvm/arm/pagetable64.S
> +++ b/plat/kvm/arm/pagetable64.S
> @@ -239,10 +239,10 @@ ENTRY(start_mmu)
>   
>           /*
>          * Invalidate the D-Cache to avoid using invalid data that existed
> -        * in D-Cache. Invalidate ranges: DTB, TEXT, DATA, BSS, PAGETABLE
> -        * and BOOTSTACK.
> +        * in D-Cache. Invalidate ranges that may have been modified:
> +        * DATA, BSS, PAGETABLE and BOOTSTACK.
>          */
> -       ldr x0, =_dtb
> +       ldr x0, =_data
>         ldr x1, =_end
>         add x1, x1, #PAGE_TABLE_SIZE
>         add x1, x1, #__STACK_SIZE
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel