[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Minios-devel] [UNIKRAFT PATCHv3 13/25] plat/kvm: Add __TRAP_STACK_SIZE for stack pointer while exiting trap
- To: Wei Chen <wei.chen@xxxxxxx>, <minios-devel@xxxxxxxxxxxxxxxxxxxx>, <simon.kuenzer@xxxxxxxxx>, <florian.schmidt@xxxxxxxxx>, <yuri.volchkov@xxxxxxxxx>, <Felipe.Huici@xxxxxxxxx>
- From: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
- Date: Fri, 11 Jan 2019 15:30:55 +0100
- Cc: Kaly.Xin@xxxxxxx, nd@xxxxxxx, Jianyong.Wu@xxxxxxx, Justin.He@xxxxxxx
- Delivery-date: Fri, 11 Jan 2019 14:31:13 +0000
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
Hello Wei Chen,
This patch seems fine.
Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
Thanks & Regards
Sharan
On 12/13/18 10:15 AM, Wei Chen wrote:
We have subtract the __TRAP_STACK_SIZE from sp while entering the tarp,
but while exiting the trap, we forgot to add __TRAP_STACK_SIZE back to
sp.
Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
---
plat/kvm/arm/exceptions.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/plat/kvm/arm/exceptions.S b/plat/kvm/arm/exceptions.S
index af039d8..edce7d3 100644
--- a/plat/kvm/arm/exceptions.S
+++ b/plat/kvm/arm/exceptions.S
@@ -103,6 +103,8 @@
ldp x2, x3, [sp, #16 * 1]
ldp x0, x1, [sp, #16 * 0]
+ add sp, sp, #__TRAP_STACK_SIZE
+
eret
.endm
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
