Re: [Minios-devel] [UNIKRAFT PATCHv3 10/25] plat/kvm: Correct invalid indent character for Arm64

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Jia He,

Please find the comment inline.


Thanks & Regards
Sharan

On 1/11/19 10:48 AM, Jia He wrote:
> Hi Sharan
>
> On 2019/1/10 23:26, Sharan Santhanam wrote:
> > Hello Wei Chen,
> >
> > This patch seems fine.
> >
> > check_patch reports a warning on the commit message which we can fix 
> > while upstreaming it.
> Could you please tell the checkpatch log?
>
> There is no error/ warning in my arm64 server:
>
> # support/scripts/checkpatch.pl 
> 0001-plat-kvm-Correct-invalid-indent-character-for-Arm64.patch
> total: 0 errors, 0 warnings, 8 lines checked
>
> 0001-plat-kvm-Correct-invalid-indent-character-for-Arm64.patch has no 
> obvious style problems and is ready for submission.
WARNING: Possible unwrapped commit description (prefer a maximum 75 
chars per line)
#7:
    Using tab to replace the spaces for the indent before 
ukplat_entry_argp.

> ---
>
> Cheers,
>
> Justin (Jia He)
>
> > Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> >
> > Thanks & Regards
> > Sharan
> >
> >
> > On 12/13/18 10:15 AM, Wei Chen wrote:
> > > Using tab to replace the spaces for the indent before ukplat_entry_argp.
> > >
> > > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > > ---
> > >   plat/kvm/arm/setup.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/plat/kvm/arm/setup.c b/plat/kvm/arm/setup.c
> > > index 14efcfd..5ffb629 100644
> > > --- a/plat/kvm/arm/setup.c
> > > +++ b/plat/kvm/arm/setup.c
> > > @@ -181,7 +181,7 @@ enocmdl:
> > >     static void _libkvmplat_entry2(void *arg __attribute__((unused)))
> > >   {
> > > -       ukplat_entry_argp(NULL, (char *)cmdline, strlen(cmdline));
> > > +    ukplat_entry_argp(NULL, (char *)cmdline, strlen(cmdline));
> > >   }
> > >     void _libkvmplat_start(void *dtb_pointer)
> > _______________________________________________
> > Minios-devel mailing list
> > Minios-devel@xxxxxxxxxxxxxxxxxxxx
> > https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel