[Minios-devel] [UNIKRAFT PATCH] plat/virtio: Update off-by-one device id

[Cristian Banu <cristb@xxxxxxxxx>]

The virtio_device_id is computed as the difference between pci_dev_id
and VIRTIO_PCI_LEGACY_DEVICEID_START. Considering the values for device
ids given in virtio_ids.h, the previous value of 0x0FFF would have
created an off-by-one error in virtio_device_id.

For example, a 9P device has pci_dev_id = 0x1009, thus virtio_device_id
would've been 0xA instead of 0x9, as required by virtio_ids.h.

Signed-off-by: Cristian Banu <cristb@xxxxxxxxx>
---
 plat/drivers/virtio/virtio_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plat/drivers/virtio/virtio_pci.c b/plat/drivers/virtio/virtio_pci.c
index 8503b534d054..44b1fc8e7f12 100644
--- a/plat/drivers/virtio/virtio_pci.c
+++ b/plat/drivers/virtio/virtio_pci.c
@@ -46,7 +46,7 @@
 #include <virtio/virtio_pci.h>
 
 #define VENDOR_QUMRANET_VIRTIO           (0x1AF4)
-#define VIRTIO_PCI_LEGACY_DEVICEID_START (0x0FFF)
+#define VIRTIO_PCI_LEGACY_DEVICEID_START (0x1000)
 #define VIRTIO_PCI_MODERN_DEVICEID_START (0x1040)
 
 static struct uk_alloc *a;
-- 
2.11.0


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel