Re: [Minios-devel] About the IRQ framework of Unikraft

["Wei Chen (Arm Technology China)" <Wei.Chen@xxxxxxx>]

Ok, let's keep the O(1), at least we can sacrifice space to improve
efficiency. For current stage, we can define __MAX_IRQ_NUM for each
architecture, and introduce irq_handlers[__MAX_IRQ_NUM]. For Arm64,
the __MAX_IRQ_NUM can be 1022. This mean, we would waste about 8 * 1000 bytes 
for irq_handlers. How about x86_64?


> -----Original Message-----
> From: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> Sent: 2018年12月3日 17:56
> To: Wei Chen (Arm Technology China) <Wei.Chen@xxxxxxx>; Florian Schmidt
> (Florian.Schmidt@xxxxxxxxx) <Florian.Schmidt@xxxxxxxxx>; Costin Lupu
> (costin.lup@xxxxxxxxx) <costin.lup@xxxxxxxxx>; costin.lupu@xxxxxxxxx; Felipe
> Huici (Felipe.Huici@xxxxxxxxx) <Felipe.Huici@xxxxxxxxx>; Yuri Volchkov
> <yuri.volchkov@xxxxxxxxx>
> Cc: minios-devel@xxxxxxxxxxxxxxxxxxxx; Kaly Xin (Arm Technology China)
> <Kaly.Xin@xxxxxxx>; Jianyong Wu (Arm Technology China) <Jianyong.Wu@xxxxxxx>;
> Justin He (Arm Technology China) <Justin.He@xxxxxxx>
> Subject: Re: About the IRQ framework of Unikraft
>
> On 03.12.18 09:38, Wei Chen (Arm Technology China) wrote:
> > So, can we change the irq_handlers[16] to a list?
>
> Hum, a list is probably to costly in the performance (O(n)). Could we
> change it to something that has O(1) for the lookups?
>
> >
> >> -----Original Message-----
> >> From: Minios-devel <minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
> >> Wei Chen (Arm Technology China)
> >> Sent: 2018年12月3日 15:14
> >> To: Simon Kuenzer (simon.kuenzer@xxxxxxxxx) <simon.kuenzer@xxxxxxxxx>;
> Florian
> >> Schmidt (Florian.Schmidt@xxxxxxxxx) <Florian.Schmidt@xxxxxxxxx>; Costin
> Lupu
> >> (costin.lup@xxxxxxxxx) <costin.lup@xxxxxxxxx>; costin.lupu@xxxxxxxxx;
> Felipe
> >> Huici (Felipe.Huici@xxxxxxxxx) <Felipe.Huici@xxxxxxxxx>; Yuri Volchkov
> >> <yuri.volchkov@xxxxxxxxx>
> >> Cc: minios-devel@xxxxxxxxxxxxxxxxxxxx; Kaly Xin (Arm Technology China)
> >> <Kaly.Xin@xxxxxxx>; Jianyong Wu (Arm Technology China)
> <Jianyong.Wu@xxxxxxx>;
> >> Justin He (Arm Technology China) <Justin.He@xxxxxxx>
> >> Subject: [Minios-devel] About the IRQ framework of Unikraft
> >>
> >> Hi,
> >>
> >> These days I am testing the multi-thread support patches on Arm64.
> >> But I find a problem about the IRQ framework. This framework can
> >> work properly for x86_64. But it can't work properly for Arm64
> >>
> >> static struct irq_handler_head irq_handlers[16];
> >>
> >> Here defined 16 irq_handlers, but on Arm64, most irq number
> >> Is higher than 16.
> >>
> >> So, in ukplat_irq_register:
> >> UK_SLIST_INSERT_HEAD(&irq_handlers[irq], h, entries);
> >> Will overflow.
> >>
> >> Regards,
> >> Wei Chen
> >> IMPORTANT NOTICE: The contents of this email and any attachments are
> >> confidential and may also be privileged. If you are not the intended
> recipient,
> >> please notify the sender immediately and do not disclose the contents to
> any
> >> other person, use it for any purpose, or store or copy the information in
> any
> >> medium. Thank you.
> >>
> >> _______________________________________________
> >> Minios-devel mailing list
> >> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> >> https://lists.xenproject.org/mailman/listinfo/minios-devel
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended 
> recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> >
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel