Re: [Minios-devel] [UNIKRAFT PATCH v2 10/10] lib/ukboot: Correct line ending of UK_CRASH() messages

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Simon.

This patch looks fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On 09/28/2018 03:25 PM, Simon Kuenzer wrote:
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   lib/ukboot/boot.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/ukboot/boot.c b/lib/ukboot/boot.c
> index cdb1ea3..174dd5b 100644
> --- a/lib/ukboot/boot.c
> +++ b/lib/ukboot/boot.c
> @@ -230,7 +230,7 @@ void ukplat_entry(int argc, char *argv[])
>         else {
>                 rc = ukplat_memallocator_set(a);
>                 if (unlikely(rc != 0))
> -                       UK_CRASH("Could not set the platform memory 
> allocator.");
> +                       UK_CRASH("Could not set the platform memory 
> allocator\n");
>         }
>   #endif
>   
> @@ -238,7 +238,7 @@ void ukplat_entry(int argc, char *argv[])
>         uk_pr_info("Initialize IRQ subsystem...\n");
>         rc = ukplat_irq_init(a);
>         if (unlikely(rc != 0))
> -               UK_CRASH("Could not initialize the platform IRQ subsystem.");
> +               UK_CRASH("Could not initialize the platform IRQ subsystem\n");
>   #endif
>   
>   	/* On most platforms the timer depend on an initialized IRQ subsystem */
> @@ -249,7 +249,7 @@ void ukplat_entry(int argc, char *argv[])
>         /* Init scheduler. */
>         s = uk_sched_default_init(a);
>         if (unlikely(!s))
> -               UK_CRASH("Could not initialize the scheduler.");
> +               UK_CRASH("Could not initialize the scheduler\n");
>   #endif
>   
>   	tma.argc = argc;
> @@ -258,7 +258,7 @@ void ukplat_entry(int argc, char *argv[])
>   #if CONFIG_LIBUKSCHED
>         main_thread = uk_thread_create("main", main_thread_func, &tma);
>         if (unlikely(!main_thread))
> -               UK_CRASH("Could not create main thread.");
> +               UK_CRASH("Could not create main thread\n");
>         uk_sched_start(s);
>   #else
>         /* Enable interrupts before starting the application */
Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel