Re: [Minios-devel] [UNIKRAFT PATCH 3/8] lib/uksched: Introduce thread attributes

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Felipe,

Thanks for your review. I'll answer inline to one of your comments.

On 9/25/18 1:01 PM, Felipe Huici wrote:
> Hi Costin,
> 
> Please see a few comments inline.
> 
> On 9/18/18, 5:27 PM, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:
> 

<snip>

>> +
>> +int uk_thread_attr_set_timeslice(uk_thread_attr_t *attr, int timeslice)
>> +{
>> +    if (attr == NULL)
>> +            return EINVAL;
>> +
>> +    /* TODO check timeslice agains platform tick */
>> +    attr->timeslice = timeslice;
>> +
>> +    return 0;
>> +}
> 
> s/agains/against. Also, when will this be implemented?

As soon as the 'plat/*: Configure timer interrupt frequency' patch gets
upstreamed we can implement this too. The patch introduces the platform
tick. I sent a v2 on the list already.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel