Re: [Minios-devel] [UNIKRAFT PATCH v3 6/8] build/Makefile.rules: Complete list of supported source file extensions

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:

> According to `man gcc`, we actually support more source file name extensions
> than currenly populated by the buildrule function in 
> support/build/Makefiles.rules.
> This commits adds support for the following extensions:
>   .sx  - Assembler file that has to be pre-processed (like .S)
>   .cp  - Another C++ file name extension (like .cc)
>   .cxx - Another C++ file name extension (like .cc)
>   .CPP - Another C++ file name extension (like .cc)
>   .c++ - Another C++ file name extension (like .cc)
>   .C   - Another C++ file name extension (like .cc)
> The intention is that porting of existing source code files is getting 
> simpler.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  support/build/Makefile.rules | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
> index 7b80ea6..a4a6b5e 100644
> --- a/support/build/Makefile.rules
> +++ b/support/build/Makefile.rules
> @@ -421,13 +421,19 @@ endef
>  # buildrule $libname,$source,$target,$extraflags(optional)
>  define buildrule =
>  $(if $(filter %.lds.S,$(2)),$(call buildrule_lds,$(1),$(2),$(3),$(4)),\
> -$(if $(filter %.S,  $(2)),$(call buildrule_S ,$(1),$(2),$(3),$(4)),\
> -$(if $(filter %.s,  $(2)),$(call buildrule_s ,$(1),$(2),$(3),$(4)),\
> -$(if $(filter %.c,  $(2)),$(call buildrule_c ,$(1),$(2),$(3),$(4)),\
> -$(if $(filter %.cc, $(2)),$(call buildrule_cc,$(1),$(2),$(3),$(4)),\
> -$(if $(filter %.cpp,$(2)),$(call buildrule_cc,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.S,    $(2)),$(call buildrule_S  ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.sx,   $(2)),$(call buildrule_S  ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.s,    $(2)),$(call buildrule_s  ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.c,    $(2)),$(call buildrule_c  ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.cc,   $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.cp,   $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.cxx,  $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.cpp,  $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.CPP,  $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.c++,  $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
> +$(if $(filter %.C,    $(2)),$(call buildrule_cc ,$(1),$(2),$(3),$(4)),\
>  $(error $(3): missing build rule for source type $(suffix $(2))) \
> -))))))
> +))))))))))))
>  endef
>  
>  
> -- 
> 2.7.4
>

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel