Re: [Minios-devel] [UNIKRAFT PATCH v3 7/8] build/Makefile.rules: Use $(RM) within build_cmd_fixdep

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:

> Instead of calling `rm -f` directly, use the command definition
> $(RM) that is declared in the main `Makefile`. This is done
> for consistency since we defined all called commands in the
> main Makefile.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  support/build/Makefile.rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
> index a4a6b5e..687ef98 100644
> --- a/support/build/Makefile.rules
> +++ b/support/build/Makefile.rules
> @@ -221,7 +221,7 @@ define build_cmd_fixdep =
>       $(call build_cmd,$1,$2,$3,$4)
>       $Q $(UK_FIXDEP) $(call tmp_depfile,$3) $3 '$(call strip,$4)' \
>               $(BUILD_DIR)    > $(call out2dep,$3) && \
> -             rm -f $(call tmp_depfile,$3)
> +             $(RM) $(call tmp_depfile,$3)
>  endef
>  
>  # Returns a list of files to be cleaned when build_cmd was used
> -- 
> 2.7.4
>

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel