Re: [Minios-devel] [UNIKRAFT PATCH v4 11/16] include/uk: prefix functions in bitmap.h and bitopts.h

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

Reviewed with one small comment:

On 09/06/2018 03:49 PM, Yuri Volchkov wrote:
> --- a/include/uk/bitops.h
> +++ b/include/uk/bitops.h
> @@ -39,8 +39,9 @@
>   #include <uk/arch/lcpu.h>
>   #include <uk/arch/atomic.h>
>   
> -#define	BIT(nr)			(1UL << (nr))
> -#define        BIT_ULL(nr)             (1ULL << (nr))
> +#define        UK_BIT(nr)                      (1UL << (nr))
> +#define        UK_BIT_ULL(nr)          (1ULL << (nr))
The alignment is broken on this pair of #defines.


--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel