Re: [Minios-devel] [UNIKRAFT PATCH v4 10/16] include/uk: adapt bitops.h, bitmap.h for Unikraft

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 09/06/2018 03:49 PM, Yuri Volchkov wrote:
> --- a/include/uk/bitops.h
> +++ b/include/uk/bitops.h
> @@ -64,14 +66,16 @@
>   #define       hweight64(x)    uk_bitcount64(x)
>   #define       hweight_long(x) uk_bitcountl(x)
>   
> +#if 0 /* TODO revisit when needed */
>   static inline int
> -fls64(uint64_t mask)
> +fls64(__u64 mask)
>   {
>         return flsll(mask);
>   }
> +#endif
I'm making a mental note of this TODO. I think this should be easy to 
re-enable in unikraft, but at the same time, I might want to clean up 
include/uk/arch/x86/x86_64/atomic.h while I'm at it.
Cheers,
Florian

--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel