Re: [Minios-devel] [UNIKRAFT PATCHv5 09/46] arch/arm: Check gcc version and set processor flags for arm32

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 10.08.2018 09:07, Wei Chen wrote:
> From: Wei Chen <Wei.Chen@xxxxxxx>
>
> Similar to ARM64, the optimization processor flags have the minimum
> gcc version requirement. So we still need to check the GCC version
> for arm32. As we have already defined a makefile function to do such
> task, so we can use this function for arm32 too.
>
> Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
> ---
>   arch/arm/arm/Makefile.uk | 17 ++++++++++++-----
>   1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/arm/Makefile.uk b/arch/arm/arm/Makefile.uk
> index a84f2b8..38ea876 100644
> --- a/arch/arm/arm/Makefile.uk
> +++ b/arch/arm/arm/Makefile.uk
> @@ -5,12 +5,19 @@ CFLAGS   += -marm -fms-extensions
>   CXXFLAGS += -D__ARM_32__
>   CXXFLAGS += -marm -fms-extensions
>   
> -#-march=armv7-a
> +# Set GCC flags for MARCH_ARM32_A20NEON. GCC supports -mcpu=cortex-a7 from 4.7
> +ifeq ($(CONFIG_MARCH_ARM32_A20NEON),y)
> +$(call error_if_gcc_version_lt,4,7)
> +CFLAGS-$(call gcc_version_ge,4,7)      += -mcpu=cortex-a7 -mtune=cortex-a7 
> -mfpu=vfpv4-d16 -mfpu=neon-vfpv4 -funsafe-math-optimizations
> +CXXFLAGS-$(call gcc_version_ge,4,7)    += -mcpu=cortex-a7 -mtune=cortex-a7 
> -mfpu=vfpv4-d16 -mfpu=neon-vfpv4 -funsafe-math-optimizations
> +endif
>   
> -CFLAGS-$(CONFIG_MARCH_ARM32_A20NEON)    += -mcpu=cortex-a7 -mtune=cortex-a7 -mfpu=vfpv4-d16 -mfpu=neon-vfpv4 -funsafe-math-optimizations
> -CXXFLAGS-$(CONFIG_MARCH_ARM32_A20NEON)  += -mcpu=cortex-a7 -mtune=cortex-a7 
> -mfpu=vfpv4-d16 -mfpu=neon-vfpv4 -funsafe-math-optimizations
> -CFLAGS-$(CONFIG_MARCH_ARM32_CORTEXA7)   += -mcpu=cortex-a7 -mtune=cortex-a7
> -CXXFLAGS-$(CONFIG_MARCH_ARM32_CORTEXA7) += -mcpu=cortex-a7 -mtune=cortex-a
> +# Set GCC flags for MARCH_ARM32_CORTEXA7. GCC supports -mcpu=cortex-a7 from 4.7
> +ifeq ($(CONFIG_MARCH_ARM32_CORTEXA7),y)
> +$(call error_if_gcc_version_lt,4,7)
> +CFLAGS-$(call gcc_version_ge,4,7)      += -mcpu=cortex-a7 -mtune=cortex-a7
> +CXXFLAGS-$(call gcc_version_ge,4,7)    += -mcpu=cortex-a7 -mtune=cortex-a7
> +endif
>   
>   $(eval $(call addlib,libarmmath))
>   LIBARMMATH_SRCS-$(CONFIG_ARCH_ARM_32) += $(CONFIG_UK_BASE)/arch/arm/divsi3.S
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel