Re: [Minios-devel] [UNIKRAFT PATCH v5 3/9] plat/linuxu: Add linuxu (x86_64) interrupts support

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Florian,


On 08/31/2018 01:42 PM, Florian Schmidt wrote:
> Hi Sharan,
>
> On 08/31/2018 11:59 AM, Sharan Santhanam wrote:
>
> > Shouldn't be uk_sigval instead of int?
> > > +
> > > +static inline int sys_sigaction(int signum, const struct 
> > > uk_sigaction *action,
> > > +        struct uk_sigaction *oldaction)
> > > +{
> > > +    return (int) syscall4(__SC_RT_SIGACTION,
> > > +                  (long) signum,
> > > +                  (long) action,
> > > +                  (long) oldaction,
> > > +                  sizeof(k_sigset_t));
> > > +}
> This looks ok to me. The syscall will only ever use the int anyway, so 
> passing an int in here is ok. The caller of the function may of course 
> use uk_sigaction, but would pass the signal number in.
I preferred it because we defined an explicit data type for signal 
number but we weren't using it in the signature.
In terms of the functionality yes I completely agree with you we would 
always use int field within the union.
> > Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> >
> > Thanks & Regards
> > Sharan
Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel