Re: [Minios-devel] [UNIKRAFT PATCH v4 1/4] build: Introduce symbols exporting for each library

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Yuri, Simon,

thanks for the patch.

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

However, I have one small side remark (see below).

On 08/24/2018 01:11 PM, Simon Kuenzer wrote:
> diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
> index e317e3d..35e2921 100644
> --- a/support/build/Makefile.rules
> +++ b/support/build/Makefile.rules
> @@ -419,9 +425,10 @@ $(call libname2preolib,$(1)): $($(call 
> vprefix_lib,$(1),OBJS)) $($(call vprefix_
>                       $($(call vprefix_lib,$(1),OBJS)) $($(call 
> vprefix_lib,$(1),OBJS-y)) \
>                       -o $(call libname2preolib,$(1)))
>   
> -$(call libname2olib,$(1)): $(call libname2preolib,$(1))
> +$(call libname2olib,$(1)): $(call libname2preolib,$(1)) $(if $(wildcard 
> $($(call vprefix_lib,$(1),EXPORTS))),$($(call vprefix_lib,$(1),EXPORTS)),)
This long if-condition in the dependencies of the rule seems a bit ugly. 
Now, it works, and I'm not an expert on makfiles, so I don't have a 
better option immediately, so I won't reject the patch; just wondering 
if there's anybody who has a better solution for this. Is there are way 
to encapsulate some of this stuff into function, so that the 
depends-line is a bit more compact?

>         $(call build_cmd,OBJCOPY,,$(call libname2olib,$(1)),\
> -               $(OBJCOPY) $(OBJCFLAGS) $(OBJCFLAGS-y) \
> +               $(OBJCOPY) $(if $(wildcard $($(call 
> vprefix_lib,$(1),EXPORTS))),--keep-global-symbols=$($(call 
> vprefix_lib,$(1),EXPORTS)),) \
Same question as above.

> +                          $(OBJCFLAGS) $(OBJCFLAGS-y) \
>                            $($(call vprefix_lib,$(1),OBJCFLAGS)) $($(call 
> vprefix_lib,$(1),OBJCFLAGS-y)) \
>                            $(call libname2preolib,$(1)) $(call 
> libname2olib,$(1)))
>   



--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel