Re: [Minios-devel] [UNIKRAFT PATCH v2 5/6] lib/nolibc: Remove unnecessary includes from header files

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 17.08.2018 09:56, Florian Schmidt wrote:
> These are unneeded for the header files themselves, and the resulting
> additional definitions if including them do not conform to the standard.
>
> Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
> ---
>   lib/nolibc/include/sys/select.h | 2 --
>   lib/nolibc/include/unistd.h     | 1 -
>   2 files changed, 3 deletions(-)
>
> diff --git a/lib/nolibc/include/sys/select.h b/lib/nolibc/include/sys/select.h
> index b5c389b..e2bc70d 100644
> --- a/lib/nolibc/include/sys/select.h
> +++ b/lib/nolibc/include/sys/select.h
> @@ -32,8 +32,6 @@
>   #ifndef __SYS_SELECT_H__
>   #define __SYS_SELECT_H__
>   
> -#include <sys/time.h>
> -
>   #ifdef __cplusplus
>   extern "C" {
>   #endif
> diff --git a/lib/nolibc/include/unistd.h b/lib/nolibc/include/unistd.h
> index 6705994..fde0327 100644
> --- a/lib/nolibc/include/unistd.h
> +++ b/lib/nolibc/include/unistd.h
> @@ -35,7 +35,6 @@
>   
>   #ifndef __UNISTD_H__
>   #define __UNISTD_H__
> -#include <stdint.h>
>   
>   #ifdef __cplusplus
>   extern "C" {
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel