Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukdebug: print DLVL_EXTRA messages only in debug build

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello,

+1 for this patch.

I agree with the approach of having 2 separate prints for these 
following reasons:
* We provide a developer with a debug framework to separate developers 
library tracing vs debug messages which are always available.
* It provide better backward compatibility.

Thanks & Regards
Sharan

On 08/01/2018 11:26 AM, Simon Kuenzer wrote:
> On 01.08.2018 08:30, Florian Schmidt wrote:
> > Hi everyone,
> >
> > On 07/31/2018 03:05 PM, Simon Kuenzer wrote:
> > > Give me a +1/0/-1.
> > I'm a 0 on this one.
> >
> > I agree that it's (slightly) less confusing than the current 
> > situation. Then again, I kinda like approaches like the linux kernel 
> > has, which allows you to set debug output per subsystem level (which I 
> > guess in our case would be libraries) because global log levels of 
> > high verbosity can end up drowning you in messages.
> Your reply confuses me. The idea is about adding the ability to enable 
> debug output (done with uk_printd()) on a subset of compile units. The 
> leveled output with message type classifications stays as is but would 
> be done with uk_printk() in the future.
> Everything is still offline decided and deployed during unikernel build 
> time. Here, we are not talking about enabling any verbosity change at 
> run-time. We could consider such a feature in the future but this poll 
> isn't about this.
> > However, I'm aware that's a bit of a larger redesign, so I'm not sure 
> > we want to go for it at the moment.
> What do you mean?
>
> > Cheers, Florian
> >
> > _______________________________________________
> > Minios-devel mailing list
> > Minios-devel@xxxxxxxxxxxxxxxxxxxx
> > https://lists.xenproject.org/mailman/listinfo/minios-devel
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel