Re: [Minios-devel] [UNIKRAFT PATCH] plat/ctors: fix double const keyword warning

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks for finding this.

Cheers,
Simon

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 30.07.2018 17:51, Yuri Volchkov wrote:
> The second const keyword does not make any difference. The array is
> not a pointer, it's address can not be changed. In this sense it is
> consts implicitly.
>
> Newer gcc complains about this.
>
> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
> ---
>   include/uk/plat/ctors.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/uk/plat/ctors.h b/include/uk/plat/ctors.h
> index 8c034af..a15d0b8 100644
> --- a/include/uk/plat/ctors.h
> +++ b/include/uk/plat/ctors.h
> @@ -46,10 +46,10 @@ typedef void (*ukplat_ctor_func_t)(void);
>   
>   /* Function pointer arrays of constructors; provided by
>    * the platform's linker script */
> -extern const ukplat_ctor_func_t const __preinit_array_start[];
> -extern const ukplat_ctor_func_t const __preinit_array_end;
> -extern const ukplat_ctor_func_t const __init_array_start[];
> -extern const ukplat_ctor_func_t const __init_array_end;
> +extern const ukplat_ctor_func_t __preinit_array_start[];
> +extern const ukplat_ctor_func_t __preinit_array_end;
> +extern const ukplat_ctor_func_t __init_array_start[];
> +extern const ukplat_ctor_func_t __init_array_end;
>   
>   /**
>    * Helper macro for iterating over constructor pointer arrays
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel