Re: [Minios-devel] automation: Creating a patchwork instance to improve pre-commit build testing

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/07/18 10:57, Lars Kurth wrote:
>
> On 24/07/2018, 10:46, "Wei Liu" <wei.liu2@xxxxxxxxxx> wrote:
>
>     On Tue, Jul 24, 2018 at 10:38:24AM +0100, Lars Kurth wrote:
>     > 
>     > 
>     > > On 24 Jul 2018, at 10:24, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
>     > > 
>     > > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote:
>     > >>>>> On 23.07.18 at 18:40, <lars.kurth@xxxxxxxxxx> wrote:
>     > >>> # How does this impact me?
>     > >>> The contribution workflow is *not* impacted by this change, but 
> once up and 
>     > >>> running the following will happen once you post a patch or patch 
> series to 
>     > >>> xen-devel:
>     > >>> * Patchwork will take patch series from the mailing list and 
> applies it
>     > >>> * CI/DC testing is triggered
>     > >>> * A test report will be sent as a mail to the patch or the series 
> (aka the 00 patch of the series)
>     > >>> 
>     > >>> This does mean though that series which do not build or show other 
> issues, 
>     > >>> will likely not be reviewed until the tests pass. This would lessen 
> the 
>     > >>> burden on reviewers, as they will know whether the code submitted 
> builds on a 
>     > >>> wide array of environments. 
>     > >> 
>     > >> So how are dependencies between series intended to be dealt with? It
>     > >> is not uncommon for someone to say "applies only on top of xyz". The
>     > >> implication of "will likely not be reviewed until the tests pass" 
> seems
>     > >> unsuitable to me in such a case.
>     > >> 
>     > > 
>     > > We have been asking everyone to rebase to staging before posting a new
>     > > version for a long time.  It is natural for the bot to assume that
>     > > everything should apply on top of staging. That would provide most 
> value
>     > > to the community.
>     > > 
>     > > For special cases like you just mention, we should aim to provide
>     > > mechanisms to manually appoint a branch to be tested.
>     > 
>     > Wei, Doug: I have another question, which is mainly for my own 
> understanding. 
>     > 
>     > Right now we allow posting of patches to Linux, Qemu, xen.git,
>     > OSSTEST, ... to xen-devel. The planned CI infrastructure only applies
>     > to xen.git. Have you thought about how to handle such cases? 
>     
>     No. I haven't.  We may be able to use some heuristics here.
>     
> Or an alternative would be to say: if you want to use the test bot then CC 
> xengit-testbot@xxxxxxxxxxxxxx (or something like it) when you submit the 
> series. That would also get around Jan's issue with dependent series: you 
> would simply not add the CC, when you know it won't build without a 
> dependency.

If you require contributors to opt into automation, people will won't
know or forget, and reviewers will first have to ask people to submit
full series again CC'ing the correct bot.

-100 to any idea which requires an opt-in.  It should be active by default.

~Andrew

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel