Re: [Minios-devel] [UNIKRAFT PATCHv4 02/43] build: Introduce a new variable UK_FAMILY

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

I will fix the typo mentioned by Julien in the message. ;-)

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 09.07.2018 09:25, Wei Chen wrote:
> > -----Original Message-----
> > From: Julien Grall <julien.grall@xxxxxxx>
> > Sent: 2018年7月8日 5:40
> > To: Wei Chen <Wei.Chen@xxxxxxx>; minios-devel@xxxxxxxxxxxxxxxxxxxx;
> > simon.kuenzer@xxxxxxxxx
> > Cc: Kaly Xin <Kaly.Xin@xxxxxxx>; nd <nd@xxxxxxx>
> > Subject: Re: [Minios-devel] [UNIKRAFT PATCHv4 02/43] build: Introduce a new
> > variable UK_FAMILY
> >
> > Hi,
> >
> > On 07/06/2018 10:03 AM, Wei Chen wrote:
> > > This patch series modifies the folder layout organized by CPU
> > > families like:
> > > unikraft----arch----arm----arm
> > >                 |      |-----arm64
> > >                 |
> > >                 |-----x86----x86
> > >                        |-----x86_64
> > >
> > > In this case, we introduce a new variable UK_FAMILY for build scipts.
> > s/scipts/scripts/
> Thanks.
> I think I'd better add spell check to my vim  : )
>
> > > we should not expect the user to set or select UK_FAMILY in a menu or
> > > by setting the variable externally. So we retrieve UK_FAMILY directly
> > > from CONFIG_UK_ARCH. Because of this we can keep Compiler.uk, Makefile.uk,
> > > and Config.uk directly under the UK_FAMILY directory.
> > >
> > > Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
> > > ---
> > >    Makefile | 10 ++++++++++
> > >    1 file changed, 10 insertions(+)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index adeaac9..178ebbc 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -338,6 +338,16 @@ endif
> > >    override ARCH := $(CONFIG_UK_ARCH)
> > >    export CONFIG_UK_ARCH ARCH
> > >
> > > +export UK_FAMILY ?= $(shell echo "$(CONFIG_UK_ARCH)" | \
> > > +                  sed -e "s/-.*//" \
> > > +                      -e 's//\1/' \
> > > +                      -e 's/x86.*/x86/' \
> > > +                      -e 's/sparc64/sparc/' \
> > > +                      -e 's/arm.*/arm/' \
> > > +                      -e 's/powerpc.*/powerpc/' \
> > > +                      -e 's/sh.*/sh/' )
> > > +
> > > +
> > >    # Quick-check if architecture exists
> > >    ifeq ($(filter $(null_targets) print-vars,$(MAKECMDGOALS)),)
> > >    ifeq ($(wildcard $(CONFIG_UK_BASE)/arch/$(ARCH)/Makefile.uk),)
> > --
> > Julien Grall
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel