Re: [Minios-devel] [UNIKRAFT PATCH v2 6/6] plat/xen: Add grant table support for Xen (x86_64)

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Julien,

On 06/28/2018 05:55 PM, Julien Grall wrote:
> Hi Costin,
> 
> On 28/06/18 13:38, Costin Lupu wrote:
>> diff --git a/plat/xen/x86/gnttab.c b/plat/xen/x86/gnttab.c
>> new file mode 100644
>> index 0000000..add3444
>> --- /dev/null
>> +++ b/plat/xen/x86/gnttab.c
> 
> All the code below does not look x86 specific. Would not it be better to
> keep that in common xen code?

Thanks for the heads-up! For now we chose to keep the arch split like
it's been in Mini-OS as a safe measure until we have the whole image of
how the design around gnttab should like after we'll have x86 HVM and
ARM support. If you'll need to move it for the ARM changes, you have my
support.

> Also, just to confirm, you are only focusing on PV support? PVH/HVM will
> likely require more work (such as calling XENMEM_add_to_physmap with
> XENMAPSPACE_grant_table during setup).

Right. In the near future we're covering the basic functionalities only
of PV support.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel