Re: [Minios-devel] [UNIKRAFT PATCHv3] build: Add no-pie to GCC flags to avoid building failed on debian distributions

[Wei Chen <Wei.Chen@xxxxxxx>]

Hi Wei Liu,

> -----Original Message-----
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
> Sent: 2018年6月25日 16:38
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: minios-devel@xxxxxxxxxxxxxxxxxxxx; simon.kuenzer@xxxxxxxxx; Kaly Xin
> <Kaly.Xin@xxxxxxx>; nd <nd@xxxxxxx>; yuri.volchkov@xxxxxxxxx;
> sharan.santhanam@xxxxxxxxx; Wei Liu <wei.liu2@xxxxxxxxxx>
> Subject: Re: [Minios-devel] [UNIKRAFT PATCHv3] build: Add no-pie to GCC flags
> to avoid building failed on debian distributions
> 
> On Thu, Jun 07, 2018 at 11:32:03AM +0800, Wei Chen wrote:
> > On debian distributions (Debian/Ubuntu), the GCC will enable the
> > "-pie" flag by default. In this case, after this patch series
> > "Introduce LTO build option"(1) had been merged, we will get
> > following error:
> >
> > X86_64 xen platform error:
> > /usr/bin/x86_64-linux-gnu-ld: -r and -pie may not be used together
> > collect2: error: ld returned 1 exit status
> > make: *** [_all] Error 2
> >
> > arm64 kvm platform error:
> >   CC      libkvmplat: shutdown.o
> >   CC      libkvmplat: memory.o
> >   LD      libkvmplat.ld.o
> > /usr/bin/aarch64-linux-gnu-ld: -r and -pie may not be used together
> > make: *** [/root/UF/unikraft/build/libkvmplat.ld.o] Error 1
> >
> > So, we need to add "-no-pie" explicitly in CFLAGS to avoid such
> > errors.
> >
> > Notes:
> > [1] https://lists.xenproject.org/archives/html/minios-devel/2018-
> 05/msg00053.html
> >
> > Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
> 
> A drive-by comment:
> 
> IIRC -no-pie is not always supported in older versions of gcc. You might
> want to check its availability before appending it.
> 

I would address this version issue in incoming Arm support patches.

Thanks,
Wei Chen

> Wei L.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel