Re: [Minios-devel] [UNIKRAFT PATCH 06/13] build: Add a makefile function to warn user when GCC is too old

[Wei Chen <Wei.Chen@xxxxxxx>]

> -----Original Message-----
> From: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> Sent: 2018年6月15日 5:17
> To: Wei Chen <Wei.Chen@xxxxxxx>; minios-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Shijie Huang <Shijie.Huang@xxxxxxx>; Kaly Xin <Kaly.Xin@xxxxxxx>; nd
> <nd@xxxxxxx>
> Subject: Re: [UNIKRAFT PATCH 06/13] build: Add a makefile function to warn
> user when GCC is too old
> 
> On 16.04.2018 11:07, Wei Chen wrote:
> > Some GCC flags, like processor flags have minimum GCC version
> > requirement. Add this makefile function to stop build and print
> > a error message to notify user that their GCC is too old.
> >
> > Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
> > ---
> >   support/build/Makefile.rules | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
> > index cc9b522..2ac729a 100644
> > --- a/support/build/Makefile.rules
> > +++ b/support/build/Makefile.rules
> > @@ -35,6 +35,13 @@ define test_gcc_version =
> >   $(shell echo 'if($(CC_VER_MAJOR).$(CC_VER_MINOR)>=$(1).$(2)) print "y"'|
> bc)
> >   endef
> >
> > +# print error when GCC version doesn't meet the minimum requirement
> > +# check_valid_gcc_version $gcc_major,$gcc_minor.
> > +define check_valid_gcc_version =
> > +$(if $(call test_gcc_version,$(1),$(2)),,\
> > +     $(error Require GCC version >= $(1).$(2) found
> $(CC_VER_MAJOR).$(CC_VER_MINOR)))
> > +endef
> > +
> 
> Maybe call it `error_if_gcc_version_lt()`, 'lt' stands for 'less than'.
> I know that I suggested `test_gcc_version` but we could also extended
> this one with `ge` ('greater or equal') to make clearer what is actually
> tested.
> 

Ok, that makes more sense. I will update it.

> >
> ##############################################################################
> ##
> >   #
> >   # Paths and Filenames
> >
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel