[Minios-devel] [UNIKRAFT PATCH] plat/kvm: Disable stripping of binaries (for now, please revisit)

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

We have to revisit stripping of KVM binaries. We noticed that sometimes
the images are broken and cannot be boot with QEMU's direct kernel boot
option (fread() error is returned).
This patch disables stripping regardless of CONFIG_OPTIMIZE_STRIP.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
 plat/kvm/Linker.uk | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/plat/kvm/Linker.uk b/plat/kvm/Linker.uk
index fa92abf..2292b03 100644
--- a/plat/kvm/Linker.uk
+++ b/plat/kvm/Linker.uk
@@ -24,10 +24,14 @@ ifeq ($(CONFIG_OPTIMIZE_SYMFILE),y)
        $(call build_cmd,NM,,$@.sym,\
               $(NM) -n $@ > $@.sym)
 endif
-ifeq ($(CONFIG_OPTIMIZE_STRIP),y)
-       $(call verbose_cmd,STRIP,$(notdir $@),\
-              $(STRIP) -s $@)
-endif
+# TODO: We have to revisit stripping of KVM binaries. We noticed that sometimes
+#       the images are broken and cannot be boot with QEMU's direct kernel boot
+#       option (fread() error is returned).
+#
+#ifeq ($(CONFIG_OPTIMIZE_STRIP),y)
+#      $(call verbose_cmd,STRIP,$(notdir $@),\
+#             $(STRIP) -s $@)
+#endif
        $(call build_cmd,GZ,,$@.gz,\
               $(GZIP) -f -9 -c $@ >$@.gz)
 endif
-- 
2.7.4


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel