Re: [Minios-devel] [UNIKRAFT PATCH 2/5] lib/ukboot: Initialize lwip on boot

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

We should put a comment as commit message to tell that this is really 
temporary and is going to disappear as soon as we have also an init 
table (like constructor and preinit table). There should be no 
dependency within the Unikraft tree pointing to an external (off-tree) 
library.
Cheers,

Simon

On 14.06.2018 20:53, Yuri Volchkov wrote:
> Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
>
> Sharan Santhanam <sharan.santhanam@xxxxxxxxx> writes:
>
> > Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> > ---
> >   lib/ukboot/boot.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/lib/ukboot/boot.c b/lib/ukboot/boot.c
> > index e6dfffa..aad9740 100644
> > --- a/lib/ukboot/boot.c
> > +++ b/lib/ukboot/boot.c
> > @@ -58,6 +58,9 @@
> >   #include <uk/argparse.h>
> >   
> >   int main(int argc, char *argv[]) __weak;
> > +#ifdef CONFIG_LIBLWIP
> > +extern int liblwip_init(void);
> > +#endif /* CONFIG_LIBLWIP */
> >   
> >   static void main_thread_func(void *arg) __noreturn;
> >   
> > @@ -80,6 +83,15 @@ static void main_thread_func(void *arg)
> >         }
> >         uk_printd(DLVL_INFO, "])\n");
> >   
> > +#ifdef CONFIG_LIBLWIP
> > +       /*
> > +        * TODO: We have an initial implementation where we call the
> > +        * initialization of some of the libraries. We might improve on this
> > +        * scheme by means of init functions in subsequent patch series
> > +        */
> > +       liblwip_init();
> > +#endif /* CONFIG_LIBLWIP */
> > +
> >         /* call main */
> >         ret = main(tma->argc, tma->argv);
> >         uk_printd(DLVL_INFO, "main returned %d, halting system\n", ret);
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > Minios-devel mailing list
> > Minios-devel@xxxxxxxxxxxxxxxxxxxx
> > https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel