[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v3 5/5] doc: add CONFIG_ to example kconfig symbols



Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 14.06.2018 19:00, Yuri Volchkov wrote:
To reflect recent modifications in the build system

Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
---
  doc/guides/developers-external-lib.rst | 2 +-
  doc/guides/developers-internal-lib.rst | 2 +-
  doc/guides/developers-platform.rst     | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/guides/developers-external-lib.rst 
b/doc/guides/developers-external-lib.rst
index feefca9..518c1fe 100644
--- a/doc/guides/developers-external-lib.rst
+++ b/doc/guides/developers-external-lib.rst
@@ -32,7 +32,7 @@ This also means that the library should be off on default.
  Since the library can be switched on and off for the build, you should use the
  following registration command for libraries instead (Makefile.uk): ::
- $(eval $(call addlib_s,libname,$(LIBNAME)))
+  $(eval $(call addlib_s,libname,$(CONFIG_LIBNAME)))
Among the same set of reserved of variable names, libraries most likely forward
  some includes and flags to the whole build, meaning also to other libraries 
and
diff --git a/doc/guides/developers-internal-lib.rst 
b/doc/guides/developers-internal-lib.rst
index 99b1a31..e1d3037 100644
--- a/doc/guides/developers-internal-lib.rst
+++ b/doc/guides/developers-internal-lib.rst
@@ -64,7 +64,7 @@ on the library API. For instance, for a new scheduler you 
would write:
Like other Unikraft libraries, you'll need a simple ``Makefile.uk``: :: - $(eval $(call addlib_s,libucschedmysched,$(LIBUKSCHEDMYSCHED)))
+  $(eval $(call addlib_s,libucschedmysched,$(CONFIG_LIBUKSCHEDMYSCHED)))
    CINCLUDES-$(LIBUKSCHEDMYSCHED)     += -I$(LIBUKSCHEDMYSCHED_BASE)/include
    CXXINCLUDES-$(LIBUKSCHEDMYSCHED)   += -I$(LIBUKSCHEDMYSCHED_BASE)/include
    LIBUKSCHEDMYSCHED_SRCS-y += $(LIBUKSCHEDMYSCHED_BASE)/mysched.c
diff --git a/doc/guides/developers-platform.rst 
b/doc/guides/developers-platform.rst
index 09c01b7..c39fbb2 100644
--- a/doc/guides/developers-platform.rst
+++ b/doc/guides/developers-platform.rst
@@ -10,7 +10,7 @@ treated as libraries in Unikraft but there are a few 
differences:
  2. You need to register the platform **and** the library with Unikraft
     using the following commands: ::
- $(eval $(call addplat_s,platname,$(PLAT_PLATNAME)))
+     $(eval $(call addplat_s,platname,$(CONFIG_PLAT_PLATNAME)))
       $(eval $(call addplatlib,platname,libplatnameplat))
3. You need to provide a linker script and name the file ``Linker.uk``.


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.