Re: [Minios-devel] [UNIKRAFT PATCH] plat/kvm: Remove prints before console is initialized (x86)

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 06/11/2018 04:40 PM, Simon Kuenzer wrote:
> Remove debug print before the console is initialized because
> this print is going to the same console device. While this
> seemed to work so far with QEMU, this may cause a problem
> at some later version of QEMU or on real hardware.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   plat/kvm/x86/console.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/plat/kvm/x86/console.c b/plat/kvm/x86/console.c
> index cfcc3cd..5ec03b0 100644
> --- a/plat/kvm/x86/console.c
> +++ b/plat/kvm/x86/console.c
> @@ -47,7 +47,6 @@
>   
>   void _libkvmplat_init_console(void)
>   {
> -       uk_printd(DLVL_INFO, "initializing serial\n");
>         outb(COM1_INTR, 0x00);  /* Disable all interrupts */
>         outb(COM1_CTRL, DLAB);  /* Enable DLAB (set baudrate divisor) */
>         outb(COM1_DIV_LO, 0x01);/* Set div to 1 (lo byte) 115200 baud */
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel