Re: [Minios-devel] [UNIKRAFT PATCH] doc: reduce pressure in 'selector' choosing instructions

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks! I am fine with this. Actually, now it is much better and fits 
with what is meant. ;-)
Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 06.06.2018 14:11, Yuri Volchkov wrote:
> The sentence "cross your fingers that the reviewer(s) do(es) not
> complain" sounds a bit too harsh. That is not the way it is
> intended. I hope this very long patch will melt some ice :)
>
> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
> ---
>   CONTRIBUTING.md | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 92912f7..9bda395 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -56,7 +56,7 @@ Where `[selector]` can be one of the following:
>              `[component]` is optional
>   
>   If no `[selector]` applies, define your own and cross your fingers that the
> -reviewer(s) do(es) not complain.
> +reviewer(s) do(es) not complain. :-)
>   
>   Sometimes a single change required multiple commit identifiers. In general this
>   should be avoided by splitting a patch into multiple ones. But for the rare
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel