[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [PATCH v3 10/43] arm64: add exception support





On 28/04/2018 07:20, Huang Shijie wrote:
On Wed, Apr 18, 2018 at 06:48:24PM +0100, Julien Grall wrote:
+    save_registers 1
+    mov     x0, sp
+    mrs     x1, esr_el1;
+    mrs     x2, far_el1;

Do you expect the mini-OS to always run with interrupt disabled in EL1? If
At the beginning, we can run with interrupt disabled in EL1.
It makes the code simple. :)

The question is more what do you expect to run in that exception context. Would it ever be possible that the C-Code will re-enable interrupt and then you get caught later on?

I am not necessarily asking you to enable the interrupt here. But you surely assess the impact of keeping interrupt disabled. Are they going to be enabled still for the thread (they run in EL1)?


not, you may want to re-enable interrupt here.
We can re-enable interrupt in future.

Thanks
Huang Shijie


Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.