Re: [Minios-devel] [PATCH v3 20/43] mini-os: implement the memmove/memchr

[Julien Grall <julien.grall@xxxxxxx>]

On 25/04/18 10:37, Huang Shijie wrote:
> On Wed, Apr 25, 2018 at 10:10:58AM +0100, Julien Grall wrote:
> > On 04/16/2018 07:32 AM, Huang Shijie wrote:
> > > This patch is split from the Chen Baozi's old patch:
> > >
> > > "This activates the ARM code added in the previous patches. On
> > >   ARM, Mini-OS will boot and display some output on the console. Tested with:"
> > >
> > > Note: The code is copied from FreeBSD code:
> > >        freebsd/contrib/ldns/compat/memmove.c
> > That's only for memmove. How about memchr?
> The memchr is also from the FreeBSD code...
You specify the file for memmove.c. But not memchr.

Also, this seems to come from a userspace application and not the 
kernel. Why not importing the assembly version (memmove.S and memcpy.S) 
that has been optimized for aarch64?
> > Also, can you explain in the commit message why you need them?
> The FDT code will need them..
It should be explained in the commit message :).

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel