Re: [Minios-devel] [PATCH v3 14/43] arm64: time.c: fix the wrong format for printk

[Huang Shijie <shijie.huang@xxxxxxx>]

On Wed, Apr 18, 2018 at 09:29:12PM +0100, Julien Grall wrote:
> 
> 
> On 16/04/2018 07:31, Huang Shijie wrote:
> >We will meet the compiler error for the current code:
> >   --------------------------------------------------
> >   time.c: In function ‘init_time’:
> >   time.c:131:12: error: format ‘%llx’ expects argument of
> >          type ‘long long unsigned int’, but argument 2 has
> >      type ‘uint64_t {aka long unsigned int}’ [-Werror=format=]
> >       printk("Virtual Count register is %llx, freq = %d Hz\n", 
> > cntvct_at_init, counter_freq);
> >                    ^
> >   cc1: all warnings being treated as errors
> >   --------------------------------------------------
> >
> >This patch fixes the compiling error.
> >
> >Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>
> >---
> >  arch/arm/time.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> >diff --git a/arch/arm/time.c b/arch/arm/time.c
> >index a088981..8d68cf0 100644
> >--- a/arch/arm/time.c
> >+++ b/arch/arm/time.c
> >@@ -5,6 +5,7 @@
> >  #include <mini-os/types.h>
> >  #include <mini-os/time.h>
> >  #include <mini-os/lib.h>
> >+#include <inttypes.h>
> 
> Where does the include "inttypes.h" come from?
The PRIX64 is defined in that file.
Maybe We can use the PRIpaddr which is defined in "arch_mm.h".

Thanks
Huang Shijie
> 
> >  //#define VTIMER_DEBUG
> >  #ifdef VTIMER_DEBUG
> >@@ -128,7 +129,8 @@ void init_time(void)
> >      __asm__ __volatile__("mrc p15, 0, %0, c14, c0, 0":"=r"(counter_freq));
> >      cntvct_at_init = read_virtual_count();
> >-    printk("Virtual Count register is %llx, freq = %d Hz\n", 
> >cntvct_at_init, counter_freq);
> >+    printk("Virtual Count register is %"PRIX64", freq = %d Hz\n",
> >+        cntvct_at_init, counter_freq);
> >  }
> >  void fini_time(void)
> >
> 
> -- 
> Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel